Ambassador 2.1.3 Released!

[Skhilled]

It's a little slow going they're coming.

I think you've understated that Steve . I didn't realise just how difficult is is to convert from SMF2.0 to SMF2.1.3

Welcome to the club! LOL

Thanks for updating Jeff's themes.

Obviously appreciated and enjoyed by many. 

Thanks, Mike.

[TwitchisMental]

Thanks, Twitch! It's a little slow going they're coming.

You're welcome. It takes some time, but once you done a few of them, it becomes a-lot easier.

I do have some suggestions, if that is okay .

One thing that you may wanna check time from time is the CSS&HTML validation. There are a few errors on this theme.

HTML Error -

Code Select Expand

    Error: Duplicate attribute class.

    At line 508, column 32

    ntertext" class="copyright"><a

CSS Errors -

1098    .quickbuttons > li > a    none is not a border-radius value : none
1525    .quick_edit    none is not a border-radius value : none
4537       Unknown pseudo-element or pseudo-class :single-button
4545       Unknown pseudo-element or pseudo-class :single-button
4545       Unknown pseudo-element or pseudo-class :vertical
4545       Unknown pseudo-element or pseudo-class :decrement
4550       Unknown pseudo-element or pseudo-class :single-button
4550       Unknown pseudo-element or pseudo-class :vertical
4550       Unknown pseudo-element or pseudo-class :decrement
4554       Unknown pseudo-element or pseudo-class :single-button
4554       Unknown pseudo-element or pseudo-class :vertical
4554       Unknown pseudo-element or pseudo-class :increment
4559       Unknown pseudo-element or pseudo-class :vertical
4559       Unknown pseudo-element or pseudo-class :single-button
4559       Unknown pseudo-element or pseudo-class :increment
4562       Parse Error }
5227    .popup_window, #main_menu .popup_window, #genericmenu .popup_window    Value Error : max-height auto is not a max-height value : auto

Also I noticed that the footer is kind of laid out wonky .(Images attached)

Change -

Code Select Expand

#footer {
margin: -130px 0 0 0;
padding: 2px 0 5px;
background: rgba(255, 255, 255, 0);
border-bottom-left-radius: 8px;
flex: none;
height: 130px;
border-bottom-right-radius: 8px;
width: auto;
align-self: center;
color: #bd9851;
}

To

Code Select Expand

#footer {
margin: -130px 0 0 0;
padding: 2px 0 5px;
background: rgba(255, 255, 255, 0);
border-bottom-left-radius: 8px;
flex: none;
height: 130px;
border-bottom-right-radius: 8px;
color: #bd9851;
width: auto;
text-align: center;
}

Everything will be aligned much better .

[Skhilled]

Any help/suggestions are always welcome! I actually have only been doing this a a little while before 2.1 beta was released but have learned a lot in a little time. LOL

I really haven't tested it much on various resolutions. Thanks! I'll do that.

[Skhilled]

1.  Footer is fixed.

2.  I "think" the HTML error is fixed. Had to look it up. I was sure I've seen multiple classes before but it's been awhile. LOL

Code Select Expand

<li class="centertext copyright">', theme_copyright(), '</li>

3.  CSS errors fixed...I "think". 

EDIT: BTW, where's the best place to look for validations? Web dev?

[TwitchisMental]

The W3C validation website.

I personally use the web developer plugin for Firefox to validate easily from a local install.
https://addons.mozilla.org/en-US/firefox/addon/web-developer/
Chrome version - https://chrome.google.com/webstore/detail/web-developer/bfbameneiokkgbdmiekhjnmfkcnldhhm

Also one other small note, you need to update the theme description information in settings.english which is found in the language folder for the theme.

Link to the updated version?, I'd be more than happy to recheck everything for you.

[Skhilled]

I haven't been to the WC3 site in ages. They've been around for a long time.

I prefer using FF myself because of Chrome's privacy issues...although, I do check to see how themes look on other browsers. Dave likes Chrome and keeps up with that for us.

I've learned to never turn down help. LOL

I've already done that. LOL I noticed it a few days ago while checking over things.

[TwitchisMental]

I haven't been to the WC3 site in ages. They've been around for a long time.

I prefer using FF myself because of Chrome's privacy issues...although, I do check to see how themes look on other browsers. Dave likes Chrome and keeps up with that for us.

I've learned to never turn down help. LOL

I've already done that. LOL I noticed it a few days ago while checking over things.

They do make the standards for the World Wide Web and have since 1994 XD .

I also prefer Firefox, but gotta check all main browsers. Thankfully with the death of Internet Explorer this isn't as bad as it use to be.

If you have already done this, the zip in the first post is not up to date?

[Skhilled]

No, I am working on some fixes now and it may be almost ready to post. But I haven't checked it for validation issues yet.

[TwitchisMental]

No, I am working on some fixes now and it may be almost ready to post. But I haven't checked it for validation issues yet.

Ah okay.

Did notice some color issues with validation background and the text color.
Find :

Code Select Expand

.valid_input {
  background: rgb(245, 255, 240);
}

Replace With

Code Select Expand

.valid_input {
  background: rgb(245, 255, 240);
  color: #000;
}

Find -

Code Select Expand

.invalid_input {
  background: rgb(255, 240, 240);
}

Replace -

Code Select Expand

.invalid_input {
  background: rgb(255, 240, 240);
  color: #000;
}

Change the color to whatever you prefer, black just seemed easiest to see contrast wise.

[Skhilled]

Changed to black...for now. LOL