News:

On Deck: Next is "Bluemoon" For SMF 2.1.4! ;)

 

Recent Topics

Members
Stats
  • Total Posts: 10,783
  • Total Topics: 1,380
  • Online today: 44
  • Online ever: 879
  • (Jan 21, 20, 05:49:15 PM)
Users Online
Users: 0
Guests: 44
Total: 44

A blue Flagrantly?

Started by voyager, Jun 06, 11, 02:51:21 AM

Previous topic - Next topic

0 Members and 4 Guests are viewing this topic.

willemjan

Quote from: ZarPrime on Jun 06, 11, 12:14:18 PM
While using the theme, go to Admin --> Configuration and select "Current Theme" from the menu.  You set the width of the theme there.  Click this image below to see it ...


ZarPrime

Actually, the wrapper div wasnt closed. That was what I tried to fix with those index.template.php files. If the div isnt showing, then that setting doesnt work. So I would love to know how voyager solved this.

ZarPrime

Will,

In that code you posted earlier ...


echo !empty($settings['forum_width']) ? '
<div id="wrapper" style="width: ' . $settings['forum_width'] . '">' : '', '
<div id="header">
<div id="head-l">
<div id="head-r">
  <div id="userarea" class="smalltext">';


... none of those div's were closed.  I don't think you posted all of the code but I never looked at the file either.

JH

voyager

I added a width to the body tag in the css.

I'm not sure how to tell which character set my forum is using, where do I find it?

ZarPrime

Willemjan,

You're right, I just looked at the whole index.template.php that voyager posted first in this topic and this div is not closed anywhere ...


<div id="wrapper" style="width: ' . $settings['forum_width'] . '">


Maybe one of us (you maybe) should mention this to Jeff.

Voyager, look in Admin, under Configuration and drop down to Languages in the menu.  The default language will have a radio enabled.

ZarPrime

voyager


willemjan

Quote from: voyager on Jun 06, 11, 12:45:55 PM
I added a width to the body tag in the css.

That is actually wrong, and could cause problems in other browsers.

Quote from: ZarPrime on Jun 06, 11, 12:52:00 PM
You're right, I just looked at the whole index.template.php that voyager posted first in this topic and this div is not closed anywhere ...


<div id="wrapper" style="width: ' . $settings['forum_width'] . '">


Maybe one of us (you maybe) should mention this to Jeff.

Correct, the wrapper part doesn't get closed. Thats why it doesn't use the setting in the admin panel. Do you know where to place the </div>? I tried it at 3 places, but none of them worked.

voyager

How can it cause problems in browsers? I made the body a fixed percentage width, it shouldn't do anything.

willemjan

Because not every browser has the same way to handle CSS properties. IE for example has an habit of showing sites wrong, while others show it correct.

ZarPrime

Quote from: willemjan on Jun 07, 11, 06:21:11 AM
Correct, the wrapper part doesn't get closed. Thats why it doesn't use the setting in the admin panel. Do you know where to place the </div>? I tried it at 3 places, but none of them worked.

Will, I'm going to have to look at the file as a whole and this might take awhile.  That div could be closed somewhere below the start of the next function.  This might take awhile, especially since I'm getting ready to go out of town today, possibly for a couple of days.

Interestingly though, I installed this theme on one of Jeff's test sites (http://www.jpr62.com/tp/index.php?theme=5) and I just now set the width in Admin to be 70% (it was at 95%) and it worked just fine for me.  Take a look.

willemjan

#49
That is indeed really odd... But then again, the blue theme is an modified theme. Its an different situation.

I'm almost positive that it has to do with the closing div tag missing

btw, your going out for fun?